Fix RCLASS_WRITE_M_TBL_WORKAROUND to avoid Ruby crash
#13988
Closed
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the current master, running `test_refinement.rb` with GC stress would cause Ruby to crash: ``` make test-all TESTS='../test/ruby/test_refinement.rb --gc-stress' ``` ``` TestRefinement#test_refine_alias_in_subclass../internal/class.h:613: Assertion Failed: RCLASS_WRITE_M_TBL_WORKAROUND:!check_promoted || !RB_OBJ_PROMOTED(klass) ``` This commit fixes the crash by applying write barrier remember to the klass, which is still a workaround, but avoids crashing Ruby with an assertion.
st0012
commented
Jul 23, 2025
|
|
||
| static inline void | ||
| RCLASS_WRITE_M_TBL_WORKAROUND(VALUE klass, struct rb_id_table *table, bool check_promoted) | ||
| RCLASS_WRITE_M_TBL_WORKAROUND(VALUE klass, struct rb_id_table *table) |
There was a problem hiding this comment.
I remove the argument as it's not used anymore, but I'm not sure if it's against any convention or we actually would want to keep it for documentation purpose...etc. Let me know if I should undo this change.
|
This is wrong so I'm closing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the current master, running
test_refinement.rbwith GC stress would cause Ruby to crash:This commit fixes the crash by applying write barrier remember to the klass, which is still a workaround, but avoids crashing Ruby with an assertion.