Block reload config files in Railtie if they already uploaded #353
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a02452 to
b43c196
Compare
cjlarose
reviewed
Mar 16, 2024
It affects tests which execute `rails runner`
d25a628 to
5db7fc4
Compare
|
@cjlarose, could you check tests? |
|
@vovanmozg are you still interested in moving forward with this PR? |
|
@Nuzair46 what do you think about this one? |
Nuzair46
reviewed
Jul 15, 2025
|
|
||
| ```ruby | ||
| Config.setup do |config| | ||
| config.load_and_set_settings("/path/to/yaml1", "/path/to/yaml2", ...) |
There was a problem hiding this comment.
As this comment suggests in the original issue #352 (comment)
I think its better to be
Config.setup { ... }
Config.load_and_set_settings("...")Because it feels more right.
|
@pkuczynski @vovanmozg the failing tests seems to be an issue with Rails 6.1 not loading logger properly. `#{Rails.root.join("bin", "rails")} runner 'print "\#{Settings.default}|\#{Settings.custom}"'`After: `RUBYOPT="-r logger" #{Rails.root.join("bin", "rails")} runner 'print "\#{Settings.default}|\#{Settings.custom}"'`This makes ruby to load the logger before anything runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352