-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Update to use rand 0.9 throughout #4254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@chriskrycho any possibility for this merge, seems quite some people get thrown off when this does not work their way. |
I was just thinking of opening a PR on this. I wonder why this hasn't been reviewed and merged yet. |
@chriskrycho People are waiting for this. |
We're currently working on updating the print version, and updating the rand crate is not going to be part of that. Once we're done with that work, we'll review this. New versions of
If people follow the instructions, there should be no problems. |
I'm not sure what you mean. Following exactly the instructions of the book (online), "specifying |
As you said, you get the same result -- the functionality of the program is not affected. Warnings are just fine, as we state here: book/src/ch01-01-installation.md Lines 12 to 14 in b2d1a08
|
Chapter 2. Programming a Guessing Game uses thread_rng() and gen_range(), which are deprecated.
I replaced every thread_rng() with rng(), and every gen_range() with random_range()
The function is also referenced in a few other areas, of which I updated.
Since this issue HERE was closed