Skip to content

large cleanup of master reference file #40411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

large cleanup of master reference file #40411

wants to merge 4 commits into from
+435 −431

Conversation

fchapoton
Copy link
Contributor

somewhat large (sorry), but only simple changes

  • about using stars around the title of articles
  • removing one duplicate
  • adding some doi links

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

dimpase
dimpase reviewed Jul 14, 2025
View reviewed changes
src/doc/en/reference/references/index.rst
@@ -152,7 +152,7 @@ REFERENCES:
.. [AGHJLPR2017] Benjamin Assarf, Ewgenij Gawrilow, Katrin Herr, Michael Joswig,
Benjamin Lorenz, Andreas Paffenholz, and Thomas Rehn,
*Computing convex hulls and counting integer points with
polymake*, Math. Program. Comput. 9 (2017), no. 1, 1–38,
polymake*, Math. Program. Comput. 9 (2017), no. 1, 1-38,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here and elsewhere, are you replacing that kind of - symbol with the "correct" one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(more precisely, "en dash" with "hyphen" (the latter the usual ASCII -) - right?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether I do the right thing. I am replacing some unicode character by just the ascii minus sign. Is this right ?

dimpase
dimpase reviewed Jul 14, 2025
View reviewed changes
@dimpase
Copy link
Member

dimpase commented Jul 14, 2025

looks good.

@fchapoton
Copy link
Contributor Author

oops, sorry, I missed that you had given a positive review already, and so added a doi as you wanted

dimpase
dimpase approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dimpase
Copy link
Member

dimpase commented Jul 14, 2025

ideally, of course, we should switch to bibfiles (sphinx supports them well). But the amount of data to convert is substantial, and can be helped if all the DOIs available are added.

@fchapoton
Copy link
Contributor Author

it seems that pdf doc does not build

[sagemath_doc_pdf-none] [spkg-install] [reference] /sage/src/doc/en/reference/references/index.rst:247: WARNING: Inline emphasis start-string without end-string. [docutils]

@fchapoton fchapoton force-pushed the clean_master_ref_file branch from 5688445 to f62cfff Compare July 16, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @dimpase
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy