Add some missing "long time" annotations #40414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the CI warning, 2025-07-14T18:34:32.9505595Z ##[warning]slow doctest: 2025-07-14T18:34:32.9523476Z f.Lattes_to_curve(check_lattes=true) 2025-07-14T18:34:32.9525823Z Test ran for 16.48s cpu, 16.65s wall by adding "# long time" to this test.
Fix the CI warnings,
2025-07-14T18:26:34.0468072Z ##[warning]slow doctest:
2025-07-14T18:26:34.0476899Z spherical.plot(cartesian, color={r:'red', th:'green', ph:'orange'})
2025-07-14T18:26:34.0478151Z Test ran for 5.28s cpu, 5.37s wall
2025-07-14T18:26:51.7069355Z ##[warning]slow doctest:
2025-07-14T18:26:51.7074158Z Du = laplacian(u)
2025-07-14T18:26:51.7078276Z Test ran for 7.21s cpu, 7.28s wall
by adding "# long time" to these tests.
Fix the CI warnings, 2025-07-14T18:37:47.9759323Z ##[warning]slow doctest: 2025-07-14T18:37:47.9761301Z test(interacts.calculus.function_tool) 2025-07-14T18:37:47.9777019Z Test ran for 5.54s cpu, 6.28s wall 2025-07-14T18:37:55.5143193Z ##[warning]slow doctest: 2025-07-14T18:37:55.5169150Z test(interacts.fractals.mandelbrot) 2025-07-14T18:37:55.5169618Z Test ran for 5.78s cpu, 7.53s wall 2025-07-14T18:38:02.1158079Z ##[warning]slow doctest: 2025-07-14T18:38:02.1159474Z test(interacts.fractals.julia) 2025-07-14T18:38:02.1159994Z Test ran for 6.21s cpu, 6.60s wall 2025-07-14T18:38:14.6948348Z ##[warning]slow doctest: 2025-07-14T18:38:14.6950545Z test(interacts.geometry.special_points) 2025-07-14T18:38:14.6951067Z Test ran for 6.04s cpu, 6.08s wall by adding "# long time" to these tests.
Fix the CI warning, 2025-07-14T18:32:50.5528101Z ##[warning]slow doctest: 2025-07-14T18:32:50.5529322Z for la in Partitions(SGA.n): 2025-07-14T18:32:50.5529772Z idem = SGA.ladder_idempotent(la) 2025-07-14T18:32:50.5530453Z assert idem^2 == idem 2025-07-14T18:32:50.5530907Z print(la, SGA.principal_ideal(idem).dimension()) 2025-07-14T18:32:50.5531396Z Test ran for 5.81s cpu, 5.89s wall by adding "# long time" to this test.
Fix the CI warnings, 2025-07-14T18:33:42.3293571Z ##[warning]slow doctest: 2025-07-14T18:33:42.3294863Z W.join() # Wait for worker to finish 2025-07-14T18:33:42.3295367Z Test ran for 12.99s cpu, 16.77s wall 2025-07-14T18:33:58.2926836Z ##[warning]slow doctest: 2025-07-14T18:33:58.2928161Z W.join() # Wait for worker to finish 2025-07-14T18:33:58.2928647Z Test ran for 13.04s cpu, 15.61s wall 2025-07-14T18:34:13.9622114Z ##[warning]slow doctest: 2025-07-14T18:34:13.9635400Z W.join() 2025-07-14T18:34:13.9639916Z Test ran for 12.89s cpu, 0.03s wall 2025-07-14T18:34:29.4681581Z ##[warning]slow doctest: 2025-07-14T18:34:29.4684229Z W.join() 2025-07-14T18:34:29.4684558Z Test ran for 12.97s cpu, 15.48s wall by adding "# long time" to these tests.
Fix the CI warning, 2025-07-14T18:36:48.3245070Z ##[warning]slow doctest: 2025-07-14T18:36:48.3247224Z hypergraphs.BinomialRandomUniform(50, 3, 1).num_blocks() # needs numpy 2025-07-14T18:36:48.3247979Z Test ran for 5.01s cpu, 5.01s wall by adding "# long time" to this test.
Fix the CI warning,
2025-07-14T18:38:36.5676939Z ##[warning]slow doctest:
2025-07-14T18:38:36.5679618Z all(SmallPermutationGroup(n,k).id() == [n,k]
2025-07-14T18:38:36.5681631Z for n in [1..64] for k in [1..numgps(n)]) # long time (180s)
2025-07-14T18:38:36.5683632Z Test ran for 67.66s cpu, 71.13s wall
by making two few improvements:
* Move the "long time" tag to the right line.
* Check only a random subset of (up to five) n and k, rather than
n <= 64 and all possible k.
|
There's a slightly confusing aspect that some |
|
Yeah, on the one hand it would be nice if the examples were self-contained. When they are, putting a single My home machine is slower than the CI, and it's amusing to note that constructing (almost) the simplest example of a differentiable manifold takes 13s cpu, meaning that the entire file using it would need to be marked "long time." In this case the performance is borderline buggy though so I'm not mad I caught it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few CI warnings by adding
# long time, and speed up one test by limiting the number of examples to a random subset.