Skip to content

Introduce FanoToricVariety_field as a Common Base Class for Gorenstein Fano Toric Varieties #40416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

local-ring
Copy link
Contributor

@local-ring local-ring commented Jul 15, 2025

Part of #40269
cc: @tscrim

This PR introduces a new base class, FanoToricVariety_field, which represents Gorenstein Fano toric varieties—toric varieties with ample Cartier anticanonical divisors. It serves as a superclass for the existing CPRFanoToricVariety_field and a forthcoming SmoothFanoToricVariety_field.

Mathematically, this reflects the natural inclusion hierarchy:
$$\text{smooth Fano} \subset \text{Gorenstein (reflexive) Fano} \subset \text{ℚ‑Fano}$$

  • The FanoToricVariety_field class abstracts the common functionality of Gorenstein Fano varieties constructed from reflexive polytopes.
  • The existing CPRFanoToricVariety_field (based on crepant partial resolutions) is refactored to inherit from this new base class.
  • Future smooth Fano varieties (from smooth reflexive polytopes) will also extend from this class.
  • Existing methods such as cartesian_product, anticanonical_hypersurface, and nef_complete_intersection, previously defined only for CPR-Fano varieties, are now lifted to the new base class, as they are valid and important in the broader Gorenstein Fano context.

The core distinction between the classes lies in the fan construction:

  • CPR-Fano varieties use crepant subdivisions of the normal fan by adding interior lattice points.
  • Fano varieties use the normal fan of polar of reflexive polytopes, no refinement
  • Smooth Fano varieties use fans from smooth reflexive polytopes, hence no resolution is required.
ToricVariety_field
├── FanoToricVariety_field        # New base class: assumes ample Cartier -K_X
│   ├── CPRFanoToricVariety_field           # Subclass: uses crepant partial resolution via coordinate_points
│   └── SmoothFanoToricVariety_field        # Subclass: assumes smooth fan directly

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy