Introduce FanoToricVariety_field
as a Common Base Class for Gorenstein Fano Toric Varieties
#40416
+574
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #40269
cc: @tscrim
This PR introduces a new base class,
FanoToricVariety_field
, which represents Gorenstein Fano toric varieties—toric varieties with ample Cartier anticanonical divisors. It serves as a superclass for the existingCPRFanoToricVariety_field
and a forthcomingSmoothFanoToricVariety_field
.Mathematically, this reflects the natural inclusion hierarchy:
$$\text{smooth Fano} \subset \text{Gorenstein (reflexive) Fano} \subset \text{ℚ‑Fano}$$
FanoToricVariety_field
class abstracts the common functionality of Gorenstein Fano varieties constructed from reflexive polytopes.CPRFanoToricVariety_field
(based on crepant partial resolutions) is refactored to inherit from this new base class.cartesian_product
,anticanonical_hypersurface
, andnef_complete_intersection
, previously defined only for CPR-Fano varieties, are now lifted to the new base class, as they are valid and important in the broader Gorenstein Fano context.The core distinction between the classes lies in the fan construction:
📝 Checklist
⌛ Dependencies