Skip to content

Limit the use of RingExtensions in Drinfeld modules #40421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Jul 16, 2025

Behaviour before this PR:
If phi is a Drinfeld module, the method phi.ore_polring() used to return an Ore polynomial ring with coefficients in RingExtension.

This causes a lot of headache because currently an instance of RingExtension does not always belong to the appropriate category and, consequently, does not implement all relevant methods and/or is not recognized as what it actually is (e.g. a finite field).

In this PR, we propose a simple fix: we let phi.ore_polring() return an Ore polynomial ring over the underlying regular field. This only changes the way things are printed, but does not alter the user interface.

We will maybe come back later to the original implementation when RingExtension will be fixed (which does not seem to be straightforward).

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@kryzar
Copy link
Contributor

kryzar commented Jul 16, 2025

Failing test unrelated to this contribution; PR accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy