Limit the use of RingExtensions in Drinfeld modules #40421
+45
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour before this PR:
If
phi
is a Drinfeld module, the methodphi.ore_polring()
used to return an Ore polynomial ring with coefficients inRingExtension
.This causes a lot of headache because currently an instance of
RingExtension
does not always belong to the appropriate category and, consequently, does not implement all relevant methods and/or is not recognized as what it actually is (e.g. a finite field).In this PR, we propose a simple fix: we let
phi.ore_polring()
return an Ore polynomial ring over the underlying regular field. This only changes the way things are printed, but does not alter the user interface.We will maybe come back later to the original implementation when
RingExtension
will be fixed (which does not seem to be straightforward).📝 Checklist