src/sage/interfaces/maxima_lib.py: remove old workaround #40424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of our Maxima monkey-patches was merged upstream some time ago: https://sourceforge.net/p/maxima/patches/102/ Now that it has been a while, we may assume that the fix is present in Maxima. As a result, the workaround from issue 31553 can be removed. Closes: sagemath#32611
|
LGTM |
nbruin
approved these changes
Jul 17, 2025
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 18, 2025
sagemathgh-40424: src/sage/interfaces/maxima_lib.py: remove old workaround One of our Maxima monkey-patches was merged upstream some time ago: https://sourceforge.net/p/maxima/patches/102/ Now that it has been a while, we may assume that the fix is present in Maxima. As a result, the workaround from sagemath#31553 can be removed. Closes: sagemath#32611 URL: sagemath#40424 Reported by: Michael Orlitzky Reviewer(s): nbruin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our Maxima monkey-patches was merged upstream some time ago: https://sourceforge.net/p/maxima/patches/102/
Now that it has been a while, we may assume that the fix is present in Maxima. As a result, the workaround from #31553 can be removed.
Closes: #32611