Simplify warnings capture with pytest

sass · asottile · Nov 11, 2018 · Nov 9, 2018 · Nov 9, 2018 · Nov 9, 2018
commit 47810313a0e8a3d42eadea15a82ffe0e5aa9e2e8
diff --git a/sasstests.py b/sasstests.py
@@ -14,7 +14,6 @@
 import tempfile
 import traceback
 import unittest
-import warnings
 
 import pytest
 from six import StringIO, b, string_types, text_type
@@ -424,14 +423,11 @@ def test_compile_string_deprecated_source_comments_line_numbers(self):
             color: red;
         }'''
         expected = sass.compile(string=source, source_comments=True)
-        with warnings.catch_warnings(record=True) as w:
-            warnings.simplefilter('always')
+        with pytest.warns(FutureWarning):
             actual = sass.compile(
                 string=source,
                 source_comments='line_numbers',
             )
-            assert len(w) == 1
-            assert issubclass(w[-1].category, FutureWarning)
         assert expected == actual
 
     def test_compile_filename(self):
@@ -465,15 +461,12 @@ def test_compile_source_map_deprecated_source_comments_map(self):
             filename=filename,
             source_map_filename='a.scss.css.map',
         )
-        with warnings.catch_warnings(record=True) as w:
-            warnings.simplefilter('always')
+        with pytest.warns(FutureWarning):
             actual, actual_map = sass.compile(
                 filename=filename,
                 source_comments='map',
                 source_map_filename='a.scss.css.map',
             )
-            assert len(w) == 1
-            assert issubclass(w[-1].category, FutureWarning)
         assert expected == actual
         self.assert_source_map_equal(expected_map, actual_map)
 
@@ -595,8 +588,7 @@ def test_output_style(self):
 class ManifestTestCase(BaseTestCase):
 
     def test_normalize_manifests(self):
-        with warnings.catch_warnings(record=True) as w:
-            warnings.simplefilter('always')
+        with pytest.warns(FutureWarning) as warninfo:
             manifests = Manifest.normalize_manifests({
                 'package': 'sass/path',
                 'package.name': ('sass/path', 'css/path'),
@@ -607,8 +599,7 @@ def test_normalize_manifests(self):
                     'strip_extension': True,
                 },
             })
-            assert len(w) == 3
-            assert all(issubclass(x.category, FutureWarning) for x in w)
+        assert len(warninfo) == 3
         assert len(manifests) == 4
         assert isinstance(manifests['package'], Manifest)
         assert manifests['package'].sass_path == 'sass/path'
@@ -635,11 +626,8 @@ def replace_source_path(s, name):
                 return s.replace('SOURCE', test_source_path(name))
 
             shutil.copytree('test', src_path)
-            with warnings.catch_warnings(record=True) as w:
-                warnings.simplefilter('always')
+            with pytest.warns(FutureWarning):
                 m = Manifest(sass_path='test', css_path='css')
-                assert len(w) == 1
-                assert issubclass(w[-1].category, FutureWarning)
 
             m.build_one(d, 'a.scss')
             with open(os.path.join(d, 'css', 'a.scss.css')) as f:
@@ -720,15 +708,12 @@ def test_wsgi_sass_middleware(self):
         with tempdir() as css_dir:
             src_dir = os.path.join(css_dir, 'src')
             shutil.copytree('test', src_dir)
-            with warnings.catch_warnings(record=True) as w:
-                warnings.simplefilter('always')
+            with pytest.warns(FutureWarning):
                 app = SassMiddleware(
                     self.sample_wsgi_app, {
                         __name__: (src_dir, css_dir, '/static'),
                     },
                 )
-                assert len(w) == 1
-                assert issubclass(w[-1].category, FutureWarning)
             client = Client(app, Response)
             r = client.get('/asdf')
             assert r.status_code == 200
@@ -828,15 +813,12 @@ def test_pysassc_stdout(self):
         assert A_EXPECTED_CSS.strip() == self.out.getvalue().strip()
 
     def test_sassc_stdout(self):
-        with warnings.catch_warnings(record=True) as w:
-            warnings.simplefilter('always')
+        with pytest.warns(FutureWarning) as warninfo:
             exit_code = sassc.main(
                 ['sassc', 'test/a.scss'],
                 self.out, self.err,
             )
-            assert len(w) == 1
-            assert issubclass(w[-1].category, FutureWarning)
-            assert 'use `pysassc`' in str(w[-1].message)
+        assert 'use `pysassc`' in warninfo[0].message.args[0]
         assert exit_code == 0
         assert self.err.getvalue() == ''
         assert A_EXPECTED_CSS.strip() == self.out.getvalue().strip()