[MRG + 2] Deprecates load_lfw_pairs and load_lfw_people #4431

vinayak-mehta · 2015-03-21T04:04:29Z

#4425 I was wondering if this needs a DeprecationWarning or some change in the doc?

coveralls · 2015-03-21T04:24:05Z

Coverage decreased (-0.0%) to 95.09% when pulling 0e16c7e on vortex-ape:deprecate_func into 3b32099 on scikit-learn:master.

landscape-bot · 2015-03-21T04:25:29Z

Code quality remained the same when pulling 0e16c7e on vortex-ape:deprecate_func into 3b32099 on scikit-learn:master.

GaelVaroquaux · 2015-03-22T13:00:08Z

What you have done is not a deprecation, but a removal :).

You need to keep the functions in, and at to them a "deprecated" decorated that says that they will be removed in 2 releases (give the release name).

The idea is that we should never break user's code without warning.

Removing them from the docs is however a good idea.

vinayak-mehta · 2015-03-22T13:40:23Z

Oops, sorry. I'll add the decorator.

Do we need to test load_lfw_pairs and load_lfw_people now that we are deprecating them? If yes, I think I need to undo the changes made to the tests.

Also, should I add a test checking if the warning is raised?

vinayak-mehta · 2015-03-22T14:01:47Z

Reverted changes made in test_lfw.py for now.

landscape-bot · 2015-03-22T14:08:57Z

Repository health decreased by 0.03% when pulling cee5082 on vortex-ape:deprecate_func into 3b32099 on scikit-learn:master.

2 new problems were found (including 2 errors and 0 code smells).
No problems were fixed.

landscape-bot · 2015-03-22T14:18:54Z

Code quality remained the same when pulling 9303efd on vortex-ape:deprecate_func into 3b32099 on scikit-learn:master.

landscape-bot · 2015-03-22T16:59:27Z

Code quality remained the same when pulling 3a385f0 on vortex-ape:deprecate_func into 3b32099 on scikit-learn:master.

landscape-bot · 2015-03-22T17:19:34Z

Code quality remained the same when pulling 6479394 on vortex-ape:deprecate_func into 2badad3 on scikit-learn:master.

coveralls · 2015-03-22T17:54:31Z

Coverage increased (+0.0%) to 95.09% when pulling 6479394 on vortex-ape:deprecate_func into 2badad3 on scikit-learn:master.

amueller · 2015-03-23T14:51:33Z

keep the tests, but catch the warnings (possibly add @ignore_warnings to them or use with warnings.catch_warnings).

amueller · 2015-03-23T14:52:15Z

Removed in 0.19 unfortunately ;) (this is the 0.17 branch)

vinayak-mehta · 2015-03-23T14:54:13Z

Oops, I'll change it.

amueller · 2015-03-23T15:24:51Z

sklearn/datasets/tests/test_lfw.py



 def test_load_fake_lfw_pairs():
-    lfw_pairs_train = load_lfw_pairs(data_home=SCIKIT_LEARN_DATA)
+    with warnings.catch_warnings():
+        lfw_pairs_train = load_lfw_pairs(data_home=SCIKIT_LEARN_DATA)


btw, is there such a test for fetch_lfw_pairs? If there is not, the tests should just be for fetch not load. If there are tests for both, just keep them

There aren't any tests for fetch_lfw_pairs or fetch_lfw_people [checked using git grep]. Maybe I could add the same tests for fetch_lfw by copying and renaming these existing tests.

Ah. Sorry then my previous guidance was wrong. I thought there were tests for both. Please rename all tests to use fetch_lfw_pairs. If you like, you can do a for loop in the tests over both functions, but I don't think this is necessary.

landscape-bot · 2015-03-23T15:44:07Z

Code quality remained the same when pulling fe23b9b on vortex-ape:deprecate_func into 2badad3 on scikit-learn:master.

landscape-bot · 2015-03-23T19:38:13Z

Repository health decreased by 0.00% when pulling 843ee88 on vortex-ape:deprecate_func into 689388a on scikit-learn:master.

1 new problem was found (including 0 errors and 1 code smell).
1 problem was fixed (including 0 errors and 1 code smell).

amueller · 2015-04-01T21:39:46Z

LGTM

vinayak-mehta · 2015-04-03T17:16:53Z

@ogrisel - can you review this? :)

Added deprecated decorator Added import statement Added tests Added newline Ignored deprecation warnings Renamed tests for fetch_lfw_ Added imports for load_lfw_

kastnerkyle · 2015-04-16T19:09:53Z

The only thing here is removing something (load_x) that isn't inline with the rest of the API, right? If so, it looks ok to me.

amueller · 2015-04-16T19:55:20Z

it removes an undocumented alias.

kastnerkyle · 2015-04-16T19:58:20Z

Ok well consider this my +1 then!

On Thu, Apr 16, 2015 at 3:55 PM, Andreas Mueller notifications@github.com
wrote:

it removes an undocumented alias.

—
Reply to this email directly or view it on GitHub
#4431 (comment)
.

[MRG + 2] Deprecates load_lfw_pairs and load_lfw_people

vinayak-mehta force-pushed the deprecate_func branch from 3a385f0 to 6479394 Compare March 22, 2015 17:16

amueller reviewed Mar 23, 2015
View reviewed changes

vinayak-mehta force-pushed the deprecate_func branch from fe23b9b to 843ee88 Compare March 23, 2015 19:05

amueller changed the title ~~Deprecates load_lfw_pairs and load_lfw_people~~ [MRG + 1] Deprecates load_lfw_pairs and load_lfw_people Apr 1, 2015

Deprecated load_lfw_pairs and load_lfw_people

ce5fada

Added deprecated decorator Added import statement Added tests Added newline Ignored deprecation warnings Renamed tests for fetch_lfw_ Added imports for load_lfw_

vinayak-mehta force-pushed the deprecate_func branch from 843ee88 to ce5fada Compare April 10, 2015 09:46

kastnerkyle changed the title ~~[MRG + 1] Deprecates load_lfw_pairs and load_lfw_people~~ [MRG + 2] Deprecates load_lfw_pairs and load_lfw_people Apr 16, 2015

amueller added a commit that referenced this pull request Jun 1, 2015

Merge pull request #4431 from vortex-ape/deprecate_func

2c79a98

[MRG + 2] Deprecates load_lfw_pairs and load_lfw_people

amueller merged commit 2c79a98 into scikit-learn:master Jun 1, 2015

amueller mentioned this pull request Jun 1, 2015

Deprecate load_lfw_pairs and load_lfw_people #4425

Closed

vinayak-mehta deleted the deprecate_func branch September 11, 2015 06:24

Uh oh!

[MRG + 2] Deprecates load_lfw_pairs and load_lfw_people #4431

[MRG + 2] Deprecates load_lfw_pairs and load_lfw_people #4431

Uh oh!

Conversation

vinayak-mehta commented Mar 21, 2015

Uh oh!

coveralls commented Mar 21, 2015

Uh oh!

landscape-bot commented Mar 21, 2015

Uh oh!

GaelVaroquaux commented Mar 22, 2015

Uh oh!

vinayak-mehta commented Mar 22, 2015

Uh oh!

vinayak-mehta commented Mar 22, 2015

Uh oh!

landscape-bot commented Mar 22, 2015

Uh oh!

landscape-bot commented Mar 22, 2015

Uh oh!

landscape-bot commented Mar 22, 2015

Uh oh!

landscape-bot commented Mar 22, 2015

Uh oh!

coveralls commented Mar 22, 2015

Uh oh!

amueller commented Mar 23, 2015

Uh oh!

amueller commented Mar 23, 2015

Uh oh!

vinayak-mehta commented Mar 23, 2015

Uh oh!

amueller Mar 23, 2015

Choose a reason for hiding this comment

Uh oh!

vinayak-mehta Mar 23, 2015

Choose a reason for hiding this comment

Uh oh!

amueller Mar 23, 2015

Choose a reason for hiding this comment

Uh oh!

landscape-bot commented Mar 23, 2015

Uh oh!

landscape-bot commented Mar 23, 2015

Uh oh!

amueller commented Apr 1, 2015

Uh oh!

vinayak-mehta commented Apr 3, 2015

Uh oh!

kastnerkyle commented Apr 16, 2015

Uh oh!

amueller commented Apr 16, 2015

Uh oh!

kastnerkyle commented Apr 16, 2015

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.