(chore): clearer handling of consolidated metadata #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
- Coverage 87.45% 85.47% -1.98%
==========================================
Files 46 46
Lines 7057 7066 +9
==========================================
- Hits 6172 6040 -132
- Misses 885 1026 +141
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in https://github.com/scverse/anndata/pull/1995/files#diff-0edf267bfe4d54327694a6b3a05f6035bd138af62140d418bc4e01b11634028bR143-R150 that handling consolidated metadata can be a bit tricky, so I make things clearer in code and documentation what should be expected. I subscribe to pydata/xarray#10122 (comment) that without the feature, cloud data is unusably slow. I would ideally like to allow folks to opt out of consolidated using zarr-developers/zarr-python#3119 instead of an argument to the
write_zarrfunction but the timeline on the release of this feature is unclear at the moment.