fix empty shape

sdpython · sdpython · Jun 13, 2023 · Jun 11, 2023 · Jun 12, 2023 · Jun 12, 2023
commit 0e73dda56c7b650e17252483f671dddadc1fb66e
diff --git a/.gitignore b/.gitignore
@@ -8,6 +8,7 @@ _cache/*
 dist/*
 build/*
 .eggs/*
+.hypothesis/*
 *egg-info/*
 _doc/auto_examples/*
 _doc/examples/_cache/*

diff --git a/onnx_array_api/npx/npx_graph_builder.py b/onnx_array_api/npx/npx_graph_builder.py
@@ -273,7 +273,7 @@ def _io(
         self, index: int, name: str, tensor_type: Optional[type], is_input: bool
     ) -> ValueInfoProto:
         """
-        Converts an input or outut into :class:`onnx.ValueInfoProto`.
+        Converts an input or output into :class:`onnx.ValueInfoProto`.
 
         :param index: index of the input or output to add
         :param name: input or output name

diff --git a/onnx_array_api/npx/npx_numpy_tensors.py b/onnx_array_api/npx/npx_numpy_tensors.py
@@ -107,13 +107,12 @@ def dims(self):
         """
         Returns the dimensions of the tensor.
         First dimension is the batch dimension if the tensor
-        has more than one dimension.
+        has more than one dimension. It is always left undefined.
         """
-        if len(self._tensor.shape) == 0:
-            return (0,)
-        if len(self._tensor.shape) == 1:
+        if len(self._tensor.shape) <= 1:
+            # a scalar (len==0) or a 1D tensor
             return self._tensor.shape
-        return (None,) + self._tensor.shape[1:]
+        return (None, *tuple(self.shape[1:]))
 
     @property
     def ndim(self):

diff --git a/onnx_array_api/npx/npx_var.py b/onnx_array_api/npx/npx_var.py
@@ -985,7 +985,7 @@ def __getitem__(self, index: Any) -> "Var":
         cst, var = Var.get_cst_var()
 
         if self.n_var_outputs != 1:
-            # Multioutut
+            # Multioutput
             if not isinstance(index, int):
                 raise TypeError(
                     f"Only indices are allowed when selecting an output, "

diff --git a/onnx_array_api/ort/ort_tensors.py b/onnx_array_api/ort/ort_tensors.py
@@ -175,12 +175,11 @@ def dims(self):
         """
         Returns the dimensions of the tensor.
         First dimension is the batch dimension if the tensor
-        has more than one dimension.
+        has more than one dimension. It is always left undefined.
         """
-        if len(self.shape) == 0:
-            return (0,)
-        if len(self.shape) == 1:
-            return tuple(self.shape)
+        if len(self._tensor.shape) <= 1:
+            # a scalar (len==0) or a 1D tensor
+            return self._tensor.shape
         return (None, *tuple(self.shape[1:]))
 
     @property