disable one test for older version of sklearn

sdpython · sdpython · Jun 5, 2023 · Mar 20, 2023 · Jun 3, 2023 · Jun 3, 2023
commit 0775586c9a3a24ed31523b836c01d6755fbcedda
diff --git a/_unittests/ut_ort/test_sklearn_array_api_ort.py b/_unittests/ut_ort/test_sklearn_array_api_ort.py
@@ -1,7 +1,8 @@
 import unittest
 import numpy as np
+from packaging.version import Version
 from onnx.defs import onnx_opset_version
-from sklearn import config_context
+from sklearn import config_context, __version__ as sklearn_version
 from sklearn.discriminant_analysis import LinearDiscriminantAnalysis
 from onnx_array_api.ext_test_case import ExtTestCase
 from onnx_array_api.ort.ort_tensors import EagerOrtTensor, OrtTensor
@@ -19,6 +20,10 @@ def take(self, X, indices, *, axis):
 
 
 class TestSklearnArrayAPIOrt(ExtTestCase):
+    @unittest.skipIf(
+        Version(sklearn_version) <= Version("1.2.2"),
+        reason="reshape ArrayAPI not followed",
+    )
     def test_sklearn_array_api_linear_discriminant(self):
         from sklearn.utils._array_api import _ArrayAPIWrapper
 

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -11,6 +11,7 @@ ml-dtypes
 onnxmltools
 onnxruntime
 openpyxl
+packaging
 pandas
 psutil
 pyquickhelper