disable the right tests

sdpython · sdpython · Nov 13, 2023 · Nov 12, 2023 · Nov 12, 2023 · Nov 12, 2023
commit 3910302b6f5a7bce63fbdf5ff6d42fbcd3771217
diff --git a/_unittests/ut_npx/test_sklearn_array_api.py b/_unittests/ut_npx/test_sklearn_array_api.py
@@ -4,7 +4,7 @@
 from onnx.defs import onnx_opset_version
 from sklearn import config_context, __version__ as sklearn_version
 from sklearn.discriminant_analysis import LinearDiscriminantAnalysis
-from onnx_array_api.ext_test_case import ExtTestCase, ignore_warnings, skipif_ci_windows
+from onnx_array_api.ext_test_case import ExtTestCase, ignore_warnings
 from onnx_array_api.npx.npx_numpy_tensors import EagerNumpyTensor
 
 
@@ -17,7 +17,6 @@ class TestSklearnArrayAPI(ExtTestCase):
         reason="reshape ArrayAPI not followed",
     )
     @ignore_warnings(DeprecationWarning)
-    @skipif_ci_windows("Unstable on Windows.")
     def test_sklearn_array_api_linear_discriminant(self):
         X = np.array(
             [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float64
@@ -40,7 +39,6 @@ def test_sklearn_array_api_linear_discriminant(self):
         reason="reshape ArrayAPI not followed",
     )
     @ignore_warnings(DeprecationWarning)
-    @skipif_ci_windows("Unstable on Windows.")
     def test_sklearn_array_api_linear_discriminant_float32(self):
         X = np.array(
             [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float32

diff --git a/_unittests/ut_ort/test_sklearn_array_api_ort.py b/_unittests/ut_ort/test_sklearn_array_api_ort.py
@@ -4,7 +4,7 @@
 from onnx.defs import onnx_opset_version
 from sklearn import config_context, __version__ as sklearn_version
 from sklearn.discriminant_analysis import LinearDiscriminantAnalysis
-from onnx_array_api.ext_test_case import ExtTestCase
+from onnx_array_api.ext_test_case import ExtTestCase, skipif_ci_windows
 from onnx_array_api.ort.ort_tensors import EagerOrtTensor, OrtTensor
 
 
@@ -16,7 +16,8 @@ class TestSklearnArrayAPIOrt(ExtTestCase):
         Version(sklearn_version) <= Version("1.2.2"),
         reason="reshape ArrayAPI not followed",
     )
-    def test_sklearn_array_api_linear_discriminant(self):
+    @skipif_ci_windows("Unstable on Windows.")
+    def test_sklearn_array_api_linear_discriminant_ort(self):
         X = np.array(
             [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float64
         )
@@ -38,7 +39,8 @@ def test_sklearn_array_api_linear_discriminant(self):
         Version(sklearn_version) <= Version("1.2.2"),
         reason="reshape ArrayAPI not followed",
     )
-    def test_sklearn_array_api_linear_discriminant_float32(self):
+    @skipif_ci_windows("Unstable on Windows.")
+    def test_sklearn_array_api_linear_discriminant_ort_float32(self):
         X = np.array(
             [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float32
         )