Removed "required" tag from failOnValidationErrors

venera-program · venera-program · commit 91c3fa6e7d16 · 2023-10-03T12:38:23.000-07:00
Signed-off-by: Venera &lt;31911811+venera-program@users.noreply.github.com&gt;
diff --git a/model/workflow.go b/model/workflow.go
@@ -507,7 +507,7 @@ type DataInputSchema struct {
 	// +kubebuilder:validation:Required
 	Schema string `json:"schema" validate:"required"`
 	// +kubebuilder:validation:Required
-	FailOnValidationErrors bool `json:"failOnValidationErrors" validate:"required"`
+	FailOnValidationErrors bool `json:"failOnValidationErrors"`
 }
 
 type dataInputSchemaUnmarshal DataInputSchema
diff --git a/model/workflow_validator_test.go b/model/workflow_validator_test.go
@@ -417,6 +417,39 @@ Key: 'Workflow.States[3].BaseState.Transition.NextState' Error:Field validation
 	StructLevelValidationCtx(t, testCases)
 }
 
+func TestDataInputSchemaStructLevelValidation(t *testing.T) {
+	baseWorkflow := buildWorkflow()
+
+	operationState := buildOperationState(baseWorkflow, "start state")
+	buildEndByState(operationState, true, false)
+	action1 := buildActionByOperationState(operationState, "action 1")
+	buildFunctionRef(baseWorkflow, action1, "function 1")
+
+	testCases := []ValidationCase{
+		{
+			Desp: "empty DataInputSchema",
+			Model: func() Workflow {
+				model := baseWorkflow.DeepCopy()
+				model.DataInputSchema = &DataInputSchema{}
+				return *model
+			},
+			Err: `workflow.dataInputSchema.schema is required`,
+		},
+		{
+			Desp: "filled Schema, default failOnValidationErrors",
+			Model: func() Workflow {
+				model := baseWorkflow.DeepCopy()
+				model.DataInputSchema = &DataInputSchema{
+					Schema: "sample schema",
+				}
+				return *model
+			},
+		},
+	}
+
+	StructLevelValidationCtx(t, testCases)
+}
+
 func TestSecretsStructLevelValidation(t *testing.T) {
 	baseWorkflow := buildWorkflow()
 

Original file line number	Diff line number	Diff line change
`@@ -507,7 +507,7 @@ type DataInputSchema struct {`
`507`	`507`	`// +kubebuilder:validation:Required`
`508`	`508`	Schema string `json:"schema" validate:"required"`
`509`	`509`	`// +kubebuilder:validation:Required`
`510`		- FailOnValidationErrors bool `json:"failOnValidationErrors" validate:"required"`
	`510`	+ FailOnValidationErrors bool `json:"failOnValidationErrors"`
`511`	`511`	`}`
`512`	`512`
`513`	`513`	`type dataInputSchemaUnmarshal DataInputSchema`