fix: ISO8601 duration wouldn't parse for valid fractional values #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
approved these changes
Apr 25, 2024
|
The ci issue should be addressed after we merge this #200 |
|
@spolti Any ETA by which this can be merged? |
|
@Kshitiz1403 can you please rebase? |
|
Rebased |
|
Fixed failing test cases |
|
@Kshitiz1403 can you please sign your commits? Just squash and sign and we can move on. |
Previously, the library utilized a parsing library for ISO8601 durations that parsed durations into integers only. This caused issues with durations containing fractional values, such as "P0.5S", which are valid ISO8601 strings but failed to parse due to the limitation of the previous library. In this commit, I've replaced the outdated parsing library with a more robust alternative. The new library properly handles fractional values, ensuring accurate parsing of ISO8601 duration strings, including cases like "P0.5S". This update enhances the functionality and reliability of the library by accommodating a broader range of ISO8601 duration formats. Additionally, it ensures compatibility with modern standards and improves the overall usability of the library. Signed-off-by: Kshitiz Agrawal <kshitizagrawal@outlook.com>
Signed-off-by: Kshitiz Agrawal <kshitizagrawal@outlook.com>
Signed-off-by: Kshitiz Agrawal <kshitizagrawal@outlook.com>
|
@ricardozanini Can we proceed to the merge? |
|
@Kshitiz1403 sorry I missed this one. Sure thing! Many thanks! |
|
Next time, you can ping me earlier, no problem!! |
|
@ricardozanini Can we also create a release? |
|
@ricardozanini Just a side note, do you know of any serverless workflow adaption for temporal workflows? |
|
@Kshitiz1403 no, I'm not familiar with this technology. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the library utilized a parsing library for ISO8601 durations that parsed durations into integers only. This caused issues with durations containing fractional values, such as "PT0.5S", which are valid ISO8601 strings but failed to parse due to the limitation of the previous library.
In this commit, I've replaced the outdated parsing library with a more robust alternative.
The new library properly handles fractional values, ensuring accurate parsing of ISO8601 duration strings, including cases like "PT0.5S". This update enhances the functionality and reliability of the library by accommodating a broader range of ISO8601 duration formats. Additionally, it ensures compatibility with modern standards and improves the overall usability of the library.