Fix tests on macOS #2123
Merged
Fix tests on macOS #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that `OSSL_PROVIDER_try_load` can leave errors on the stack.
sfackler
reviewed
Dec 9, 2023
| @@ -55,6 +55,10 @@ impl Provider { | |||
| retain_fallbacks as _, | |||
| ))?; | |||
|
|
|||
| // OSSL_PROVIDER_try_load seems to leave errors on the stack, even | |||
| // when it succeeds. | |||
| let _ = ErrorStack::get(); | |||
There was a problem hiding this comment.
I assume this is a regression in 3.2? We should probably file a bug upstream if so.
There was a problem hiding this comment.
I'm not sure what changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
OSSL_PROVIDER_try_loadcan leave errors on the stack.