Optimize value_iterator::get_string() #2211
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lemire I'd like to confirm it before making the PR ready for review I believe the current changes are not covering all cases we've talked about. In case the character
is it correct? |
lemire
reviewed
Jul 11, 2024
| const char* start = raw_json_string_result.value_unsafe().raw(); | ||
| const char* json = start; | ||
|
|
||
| for (; *json != '\0'; ++json) { |
There was a problem hiding this comment.
You don't think you need *json != '\0'... and, in fact, it is likely incorrect. The JSON spec does not forbig null characters inside the string as far as I can tell, and it does not enforce that the string be null terminated.
|
Let me do some work of my own (next few hours). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #1470