gitbase: implement table checksums #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
jfontan
approved these changes
Jan 11, 2019
kuba--
reviewed
Jan 11, 2019
| buf.WriteString(head.Hash().String()) | ||
| } | ||
|
|
||
| refs, err := repo.References() |
There was a problem hiding this comment.
It may not work. I came across situation where ref iterator returns refs in random order - we have to double check it.
|
|
|
Yes, until the pr on go mysql server is merged I cannot update it here. It’s not going to compile until then.
…On 11 Jan 2019, 18:48 +0100, Kuba Podgórski ***@***.***>, wrote:
table.go:12: undefined: sql.Checksumable
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
|
go-mysql-server PR was already merged, so just updated the dependency and tests should be working fine now. |
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #661
Depends on src-d/go-mysql-server#583
Tests will fail until that PR is merged and this is updated.
Basically, this implements the new
sql.Checksumableinterface in each table so the engine can perform the checksums on the repos.How is the checksum implemented?
With a hash built using the repo ID, all the reference names and the hashes they point to and the checksum of all their packfiles.
If there's a single thing of those that changed, the checksum will be different.
Bad part of this? Pool is needed again in the tables :/ The checksums are checked as part of the init phase of the engine, and there is no context to get the repos from.