This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Make conversion error clearer and less detailed. #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kuba-- <kuba@sourced.tech>
jfontan
approved these changes
Nov 21, 2018
|
It would be nice to have the expression that fails to be casted but I suppose you don't have that information at that point. |
|
I have it on the higher level, but not here. On the other hand on the higher level it's hard to figure out what is the error, because it comes from go-mysql-server/sql/expression/convert.go Line 187 in 5902fdb we have to do this ugly thing! |
ajnavarro
approved these changes
Nov 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
Closes src-d/gitbase#615