Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

*: fix query cancellation #565

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Conversation

erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Nov 29, 2018

Related to src-d/gitbase#636

It was actually a few things:

  • Tables were not checking cancels
  • Exchange was not checking them correctly
  • KillConnection on the ProcessList was not working as expected
  • Kill query does not kill the query but all queries running in the connection (because you pass the connection id, not the query id)

Added a few tests that where missing as well to ensure cancellation is not broken again

@erizocosmico erizocosmico requested a review from a team November 29, 2018 15:53
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@ajnavarro ajnavarro merged commit 12091f6 into src-d:master Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy