This repository was archived by the owner on Jan 28, 2021. It is now read-only.
analyzer: fix fields of subqueries too on prune_columns #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
approved these changes
Dec 13, 2018
kuba--
approved these changes
Dec 13, 2018
jfontan
approved these changes
Dec 13, 2018
47d2551 to
ec6bee6
Compare
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, removes
subqueryBarrier, asSubqueryAliasalready acts as a barrier.Since the subqueries are fully analyzed way before the main tree gets to prune_columns, it's important that in this last pass the field fixing is done for every part of the tree to consolidate the schema after later rules have been executed on the subquery trees.