This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql/(analyzer,parse,expression): implement case expression #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
approved these changes
Dec 21, 2018
kuba--
reviewed
Dec 21, 2018
| @@ -46,6 +53,7 @@ var DefaultValidationRules = []Rule{ | |||
| {validateSchemaSourceRule, validateSchemaSource}, | |||
| {validateProjectTuplesRule, validateProjectTuples}, | |||
| {validateIndexCreationRule, validateIndexCreation}, | |||
| {validateCaseResultTypesRule, validateCaseResultTypes}, | |||
There was a problem hiding this comment.
Just open question - doesn't make sense as a optimization to squash some rules?
For instance instead of 3 times looping, we may have one loop with some cases - loud thinking.
There was a problem hiding this comment.
this query phase is really fast compared with the rest. The idea of having separated rules is the synergy that we can obtain executing them again and again, interacting with other rules.
kuba--
approved these changes
Dec 21, 2018
jfontan
approved these changes
Dec 21, 2018
mcarmonaa
approved these changes
Jan 2, 2019
|
@erizocosmico could you rebase please? |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
ba2b9d3 to
1071055
Compare
|
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #575