Added tests for VarChar

Added note about VarChar in MysqlTypeToType Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
src-d · ajnavarro · Jul 3, 2019 · Jun 20, 2019 · Jun 28, 2019 · Jun 28, 2019
commit 2f838364cad96c6aaeb68858f15c8fded7ee4337
@@ -28,6 +28,13 @@ func TestNullIf(t *testing.T) {
 	)
 	require.Equal(t, sql.Text, f.Type())
 
+	var3 := sql.VarChar(3)
+	f = NewNullIf(
+		expression.NewGetField(0, var3, "ex1", true),
+		expression.NewGetField(1, var3, "ex2", true),
+	)
+	require.Equal(t, var3, f.Type())
+
 	for _, tc := range testCases {
 		v, err := f.Eval(sql.NewEmptyContext(), sql.NewRow(tc.ex1, tc.ex2))
 		require.NoError(t, err)

@@ -14,6 +14,8 @@ type Literal struct {
 
 // NewLiteral creates a new Literal expression.
 func NewLiteral(value interface{}, fieldType sql.Type) *Literal {
+	// TODO(juanjux): we should probably check here if the type is sql.VarChar and the
+	// Capacity of the Type and the length of the value, but this can't return an error
 	return &Literal{
 		value:     value,
 		fieldType: fieldType,

@@ -3,8 +3,8 @@ package expression
 import (
 	"testing"
 
-	"github.com/stretchr/testify/require"
 	"github.com/src-d/go-mysql-server/sql"
+	"github.com/stretchr/testify/require"
 )
 
 func TestTuple(t *testing.T) {

@@ -33,7 +33,7 @@ var (
 	// ErrValueNotNil is thrown when a value that was expected to be nil, is not
 	ErrValueNotNil = errors.NewKind("value not nil: %#v")
 
-	// ErrNotTuple is retuned when the value is not a tuple.
+	// ErrNotTuple is returned when the value is not a tuple.
 	ErrNotTuple = errors.NewKind("value of type %T is not a tuple")
 
 	// ErrInvalidColumnNumber is returned when a tuple has an invalid number of
@@ -200,8 +200,6 @@ var (
 	Date dateT
 	// Text is a string type.
 	Text textT
-	// VarChar is a string type with a length.
-	VarChar varcharT
 	// Boolean is a boolean type.
 	Boolean booleanT
 	// JSON is a type that holds any valid JSON object.
@@ -220,6 +218,11 @@ func Array(underlying Type) Type {
 	return arrayT{underlying}
 }
 
+// VarChar returns a new VarChar type of the given length.
+func VarChar(length int) Type {
+	return varCharT{length: length}
+}
+
 // MysqlTypeToType gets the column type using the mysql type
 func MysqlTypeToType(sql query.Type) (Type, error) {
 	switch sql {
@@ -249,10 +252,12 @@ func MysqlTypeToType(sql query.Type) (Type, error) {
 		return Timestamp, nil
 	case sqltypes.Date:
 		return Date, nil
-	case sqltypes.VarChar:
-		return VarChar, nil
 	case sqltypes.Text:
 		return Text, nil
+	case sqltypes.VarChar:
+		// Since we can't get the size of the sqltypes.VarChar to instantiate a
+		// specific VarChar(length) type we return a Text here
+		return Text, nil
 	case sqltypes.Bit:
 		return Boolean, nil
 	case sqltypes.TypeJSON:
@@ -557,28 +562,35 @@ func (t dateT) Compare(a, b interface{}) (int, error) {
 	return 0, nil
 }
 
-type varcharT struct{
+type varCharT struct {
 	length int
 }
 
-func (t varcharT) String() string { return fmt.Sprintf("VARCHAR(%d)", t.length) }
+func (t varCharT) Capacity() int { return t.length }
+
+func (t varCharT) String() string { return fmt.Sprintf("VARCHAR(%d)", t.length) }
 
 // Type implements Type interface
-func (t varcharT) Type() query.Type {
+func (t varCharT) Type() query.Type {
 	return sqltypes.VarChar
 }
 
 // SQL implements Type interface
-func (t varcharT) SQL(v interface{}) sqltypes.Value {
-	if _, ok := v.(nullT); ok {
-		return sqltypes.NULL
+func (t varCharT) SQL(v interface{}) (sqltypes.Value, error) {
+	if v == nil {
+		return sqltypes.MakeTrusted(sqltypes.VarChar, nil), nil
 	}
 
-	return sqltypes.MakeTrusted(sqltypes.VarChar, []byte(MustConvert(t, v).(string)))
+	v, err := t.Convert(v)
+	if err != nil {
+		return sqltypes.Value{}, err
+	}
+
+	return sqltypes.MakeTrusted(sqltypes.VarChar, []byte(v.(string))), nil
 }
 
 // Convert implements Type interface
-func (t varcharT) Convert(v interface{}) (interface{}, error) {
+func (t varCharT) Convert(v interface{}) (interface{}, error) {
 	val, err := cast.ToStringE(v)
 	if err != nil {
 		return nil, ErrConvertToSQL.New(t)
@@ -591,9 +603,10 @@ func (t varcharT) Convert(v interface{}) (interface{}, error) {
 }
 
 // Compare implements Type interface.
-func (t varcharT) Compare(a interface{}, b interface{}) (int, error) {
+func (t varCharT) Compare(a interface{}, b interface{}) (int, error) {
 	return strings.Compare(a.(string), b.(string)), nil
 }
+
 type textT struct{}
 
 func (t textT) String() string { return "TEXT" }
@@ -972,11 +985,12 @@ func IsDecimal(t Type) bool {
 
 // IsText checks if t is a text type.
 func IsText(t Type) bool {
-	return t == Text || t == Blob || t == JSON || t == VarChar
+	return t == Text || t == Blob || t == JSON || IsVarChar(t)
 }
 
 func IsVarChar(t Type) bool {
-	return t == VarChar
+	_, ok := t.(varCharT)
+	return ok
 }
 
 // IsTuple checks if t is a tuple type.

@@ -24,6 +24,10 @@ func TestText(t *testing.T) {
 	lt(t, Text, "a", "b")
 	eq(t, Text, "a", "a")
 	gt(t, Text, "b", "a")
+
+	var3, err := VarChar(3).Convert("abc")
+	require.NoError(t, err)
+	convert(t, Text, var3, "abc")
 }
 
 func TestInt32(t *testing.T) {
@@ -237,6 +241,38 @@ func TestTuple(t *testing.T) {
 	gt(t, typ, []interface{}{1, 2, 4}, []interface{}{1, 2, 3})
 }
 
+func TestVarChar(t *testing.T) {
+	typ := VarChar(3)
+	require.True(t, IsVarChar(typ))
+	require.True(t, IsText(typ))
+	convert(t, typ, "foo", "foo")
+	fooByte := []byte{'f', 'o', 'o'}
+	convert(t, typ, fooByte, "foo")
+
+	typ = VarChar(1)
+	convertErr(t, typ, "foo")
+	convertErr(t, typ, fooByte)
+	convertErr(t, typ, 123)
+
+	typ = VarChar(10)
+	convert(t, typ, 123, "123")
+	convertErr(t, typ, 1234567890123)
+
+	convert(t, typ, "", "")
+	convert(t, typ, 1, "1")
+
+	lt(t, typ, "a", "b")
+	eq(t, typ, "a", "a")
+	gt(t, typ, "b", "a")
+
+	text, err := Text.Convert("abc")
+	require.NoError(t, err)
+
+	convert(t, typ, text, "abc")
+	typ1 := VarChar(1)
+	convertErr(t, typ1, text)
+}
+
 func TestArray(t *testing.T) {
 	require := require.New(t)