This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Fix typos and make style consistent #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change all functions descriptions in README.md to stick to the lower-case present-tense style, so each row is read as "Function X returns/changes/adds Y". - Fix typos in supported_clients.md. Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
erizocosmico
approved these changes
Aug 15, 2019
ajnavarro
reviewed
Aug 15, 2019
| @@ -16,7 +16,7 @@ These are the clients we actively test against to check are compatible with go-m | |||
| - Java/JVM | |||
| - [mariadb-java-client](#mariadb-java-client) | |||
| - Go | |||
| - [go-mysql-driver/mysql](#go-mysql-driver-mysql) | |||
| - [go-mysql-driver/mysql](#go-sql-drivermysql) | |||
There was a problem hiding this comment.
just to check, is this anchor correct?
There was a problem hiding this comment.
It is. It did not work before the change.
ajnavarro
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function X returns/changes/adds... Y. This is opinionated (consistency should be not), so I'm ok discussing the best style and changing it again once we agree on one.