Remove not longer required Sulu Kernel Browser #7718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to wait for the release of symfony/symfony#59185 to test this PR correctly. |
51138f5 to
9a61030
Compare
|
Also refs #7547 |
b66ba86 to
1a60c91
Compare
mamazu
reviewed
Mar 25, 2025
Comment on lines
25
to
28
| public function build(ContainerBuilder $container): void | ||
| { | ||
| parent::build($container); | ||
|
|
||
| $container->addCompilerPass(new ReplaceTestClientPass()); | ||
| } |
There was a problem hiding this comment.
If this method is empty now it can also be removed.
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove not longer required Sulu Kernel Browser.
Why?
We have a min requirement to Symfony 5.4 so this BC bridge can be removed.