Skip to content

feat: batch endpoints for column creation and retrieval #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+320 −67
Open

feat: batch endpoints for column creation and retrieval #206

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5a6782
feat: batch endpoints for column creation and retrieval
darora Mar 19, 2022
6fd3b24
wip
darora Mar 20, 2022
69515d8
chore: use typebox for column create args type
soedirgo Mar 20, 2022
cafcf99
chore(server): validate batch column create
soedirgo Mar 20, 2022
dc86a6e
fix(lib/columns): error handling
soedirgo Mar 20, 2022
358f683
chore(lib/columns): show error for all invalid cols
soedirgo Mar 21, 2022
fe11fbf
fix: don't assign to request.body
soedirgo Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(lib/columns): show error for all invalid cols
  • Loading branch information
@soedirgo
soedirgo committed Mar 21, 2022
commit 358f683fc31e4a720b1c69444a549455d8c0d282
9 changes: 6 additions & 3 deletions src/lib/PostgresMetaColumns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,12 @@ export default class PostgresMetaColumns {
if (ids && ids.length > 0) {
const regexp = /^(\d+)\.(\d+)$/

const invalidId = ids.find((id) => !regexp.test(id))
if (invalidId) {
return { data: null, error: { message: `Invalid format for column ID: ${invalidId}` } }
const invalidIds = ids.filter((id) => !regexp.test(id))
if (invalidIds.length > 0) {
return {
data: null,
error: { message: `Invalid format for column IDs: ${invalidIds.join(', ')}` },
}
}

const filteringClauses = ids
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy