Skip to content

fix: [#554] fixed tests/test_session.py::test_token_cookie_expires dst issue #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mavwolverine
Copy link
Contributor

@mavwolverine mavwolverine commented Jan 1, 2025

Summary of change

Fixed tests/test_session.py::test_token_cookie_expires test failing due to Python's dst issue

Related issues

Test Plan

INSTALL_DIR=../supertokens-root pytest -vv tests/test_session.py::test_token_cookie_expires

@mavwolverine
Copy link
Contributor Author

@sattvikc updated changelog

@namsnath
Copy link
Contributor

Hi @mavwolverine,
I'm closing this PR out in favor of #557.
Added some additional changes there on top of the ones you suggested here to ensure consistency across the codebase, and added you as a co-author.

Thanks a lot for the contribution!

@namsnath namsnath closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy