feat: plugins #594
feat: plugins #594
Conversation
2dee1be to
ca412e5
Compare
|
✅ No documentation updates required. |
| @@ -25,23 +25,21 @@ | |||
| from .recipe import EmailPasswordRecipe | |||
|
|
|||
| exceptions = ex | |||
| InputOverrideConfig = utils.InputOverrideConfig | |||
| EmailPasswordOverrideConfig = utils.EmailPasswordOverrideConfig | |||
There was a problem hiding this comment.
Should this be InputOverrideConfig = ?
|
|
||
| from .recipe import DashboardRecipe | ||
|
|
||
| InputOverrideConfig = utils.InputOverrideConfig | ||
| DashboardOverrideConfig = utils.DashboardOverrideConfig |
There was a problem hiding this comment.
Should this be InputOverrideConfig = ?
| from . import types | ||
| from .recipe import AccountLinkingRecipe | ||
|
|
||
| InputOverrideConfig = types.InputOverrideConfig | ||
| AccountLinkingOverrideConfig = types.AccountLinkingOverrideConfig |
There was a problem hiding this comment.
Should this be InputOverrideConfig = ?
|
|
||
| from .recipe import JWTRecipe | ||
| from .utils import OverrideConfig | ||
| from .utils import JWTOverrideConfig |
There was a problem hiding this comment.
Does this require exporting as InputOverrideConfig (like other recipes)?
| @@ -70,7 +72,7 @@ def __init__( | |||
| request: BaseRequest, | |||
| response: BaseResponse, | |||
| recipe_id: str, | |||
| config: JWTConfig, | |||
| config: "NormalisedJWTConfig", | |||
There was a problem hiding this comment.
Why is this not imported?
| from supertokens_python.supertokens import AppInfo | ||
|
|
||
| from ...recipe_module import RecipeModule | ||
| from supertokens_python.supertokens import RecipeInit |
There was a problem hiding this comment.
Doesn't TOTP have an override config?
|
|
||
|
|
||
| def init( | ||
| override: Union[utils.InputOverrideConfig, None] = None, | ||
| ) -> Callable[[AppInfo], RecipeModule]: | ||
| override: Union[utils.UserMetadataOverrideConfig, None] = None, |
There was a problem hiding this comment.
Override config not exported?
|
|
||
|
|
||
| def init( | ||
| skip_adding_roles_to_access_token: Optional[bool] = None, | ||
| skip_adding_permissions_to_access_token: Optional[bool] = None, | ||
| override: Union[utils.InputOverrideConfig, None] = None, | ||
| ) -> Callable[[AppInfo], RecipeModule]: | ||
| override: Union[utils.UserRolesOverrideConfig, None] = None, |
There was a problem hiding this comment.
Override config not exported?
| @@ -60,6 +61,9 @@ def init(config: Optional[WebauthnConfig] = None): | |||
|
|
|||
| __all__ = [ | |||
| "init", | |||
| "APIInterface", | |||
| "RecipeInterface", | |||
| "WebauthnOverrideConfig", | |||
There was a problem hiding this comment.
Should this be exported as InputOverrideConfig ?
| @@ -93,7 +96,7 @@ class TypeWebauthnRecoverAccountEmailDeliveryInput(CamelCaseBaseModel): | |||
| class APIOptions(CamelCaseBaseModel): | |||
| recipe_implementation: RecipeInterface | |||
| app_info: AppInfo | |||
| config: NormalisedWebauthnConfig | |||
| config: "NormalisedWebauthnConfig" | |||
There was a problem hiding this comment.
I see this imported for TYPE_CHECKING
|
Hi @sattvikc ,
For the comments about quoted types, these are mainly to fix circular import issues since types used in classes need to be imported for use, or annotated (as done here) |
- Matches plugin eval order to Node - Adds recursive dependency resolution - Adds tests for overrides and dependencies
- Defines aliases for old override config classes for backward compatibility - Adds `__all__` to recipe `__init__` files to explicitly declare exports - FIxes `apply_plugins` config input/return type - Adds ruff rule to format `__all__` exports - Updates changelog
7b4083f to
5b1f37e
Compare
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR