Skip to content

feat: removes default default_max_age from all built-in claims #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: feat/plugin/experiment
Choose a base branch
from
Open

feat: removes default default_max_age from all built-in claims #607

wants to merge 23 commits into from

Conversation

namsnath
Copy link
Contributor

@namsnath namsnath commented Jul 23, 2025 •
edited
Loading

Summary of change

  • Removes default default_max_age from all built-in claims

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

namsnath added 22 commits July 3, 2025 10:59
@namsnath
feat: adds basic plugin functionality
c14bf4f
@namsnath
feat: make plugins functional
4d2315b 
- Matches plugin eval order to Node
- Adds recursive dependency resolution
- Adds tests for overrides and dependencies
@namsnath
update: change plugin evaluation order
d797cf0
@namsnath
update: move plugin logic to function, add config override support
eca89e6
@namsnath
update: cleanup load_plugins
1b92e10
@namsnath
test: st config overrides, route handlers
e3ad95f
@namsnath
refactor: move classes to new file
66235b9
@namsnath
update: import order
f28792f
@namsnath
update: adds tests
563cf45
@namsnath
update: adds init tests
e4d95f0
@namsnath
refactor: use base classes for configs/overrides/interfaces
1e6fff1
@namsnath
fix: cyclic imports
97f831a
@namsnath
try to make types work with subclasses
7ff0126
@namsnath
refactor: rename classes for consistency, fix plugin types
1a73dc4
@namsnath
fix: accountlinking recipe get_instance, tests
aacfce5
@namsnath
fix: servers
eecf3ad
@namsnath
fix: servers
dd2b009
@namsnath
fix: webauthn email ingredient types, bump pyright
ca412e5
@namsnath
update: address TODOs
ff71d2a
@namsnath
feat: setup common util for config override normalisation
9df9427
@namsnath
fix: circular imports, add tests for config override
5cb4669
@namsnath
feat: removes default default_max_age from all built-in claims
d63342d
@namsnath namsnath self-assigned this Jul 23, 2025
@namsnath namsnath requested a review from porcellus July 23, 2025 05:44
@namsnath namsnath force-pushed the feat/plugin/experiment branch from 7b4083f to 5b1f37e Compare July 25, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcellus porcellus porcellus approved these changes

Assignees

@namsnath namsnath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namsnath @porcellus
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy