Better detection version #2801
Merged
Better detection version #2801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dummdidumm should be better now. |
dummdidumm
approved these changes
Jul 18, 2025
|
|
||
| if ( | ||
| versionToCheck.includes('latest') || | ||
| versionToCheck.includes('catalog:') || |
There was a problem hiding this comment.
wondering if we should investigate supporting that. Could be as easy as travering upwards searching for a pnpm workspace file
There was a problem hiding this comment.
Yes but, then you have bun as well (another look for file)...
I was also thinking: Maybe we should not check for package.json, but the installed package in node_modules directly ? Like this, we don't care about pnpm & bun & latest, it's what is installed.
But then it will work only if node_modules are here (maybe good enough ?)
I'm thinking for a long time about doing a package "solving" this!
Let me know what is in your mind :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semver(I started to re implement... but it's probably not too much point!)