Skip to content

chore: rewrite set_class() to handle directives #15352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 24, 2025
Merged

chore: rewrite set_class() to handle directives #15352

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5576114
set_class with class: directives
adiguba Feb 21, 2025
42860b6
update expected result (remove leading space)
adiguba Feb 21, 2025
0073e0d
fix
adiguba Feb 21, 2025
2b3fb8e
optimize literals
adiguba Feb 21, 2025
1cbb44b
add test
adiguba Feb 21, 2025
2ae5869
add test for mutations on hydration
adiguba Feb 21, 2025
be008ae
clean observer
adiguba Feb 21, 2025
559c168
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
adiguba Feb 22, 2025
203ba37
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
adiguba Feb 22, 2025
412fe18
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
adiguba Feb 22, 2025
a4b7280
Update packages/svelte/src/compiler/phases/3-transform/server/visitor…
adiguba Feb 22, 2025
86fb42f
Update packages/svelte/src/internal/client/dom/elements/attributes.js
adiguba Feb 22, 2025
8f3c108
Update packages/svelte/src/internal/shared/attributes.js
adiguba Feb 22, 2025
bf9c305
remove unused + fix JSDoc
adiguba Feb 22, 2025
ec4709f
drive-by fix
Rich-Harris Feb 22, 2025
2704f61
minor style tweaks
Rich-Harris Feb 22, 2025
f96124b
tweak test
Rich-Harris Feb 22, 2025
a5ff0bb
this is faster
Rich-Harris Feb 22, 2025
395debd
tweak
Rich-Harris Feb 22, 2025
501f726
tweak
Rich-Harris Feb 24, 2025
296193b
this is faster
Rich-Harris Feb 24, 2025
b9f90bd
typo
Rich-Harris Feb 24, 2025
456be79
tweak
Rich-Harris Feb 24, 2025
b4bcaf4
changeset
Rich-Harris Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update expected result (remove leading space)
  • Loading branch information
@adiguba
adiguba committed Feb 21, 2025
commit 42860b6b3882ba9aad63199d7bc01959a319a880
2 changes: 1 addition & 1 deletion packages/svelte/tests/css/samples/undefined-with-scope/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<p class=" svelte-xyz">Foo</p>
<p class="svelte-xyz">Foo</p>
10 changes: 5 additions & 5 deletions packages/svelte/tests/runtime-legacy/samples/attribute-null-classname-with-style/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import { ok, test } from '../../test';

export default test({
html: '<div class=" svelte-x1o6ra"></div>',
html: '<div class="svelte-x1o6ra"></div>',

test({ assert, component, target }) {
const div = target.querySelector('div');
ok(div);

component.testName = null;
assert.equal(div.className, ' svelte-x1o6ra');
assert.equal(div.className, 'svelte-x1o6ra');

component.testName = undefined;
assert.equal(div.className, ' svelte-x1o6ra');
assert.equal(div.className, 'svelte-x1o6ra');

component.testName = undefined + '';
assert.equal(div.className, 'undefined svelte-x1o6ra');
Expand All @@ -32,10 +32,10 @@ export default test({
assert.equal(div.className, 'true svelte-x1o6ra');

component.testName = {};
assert.equal(div.className, ' svelte-x1o6ra');
assert.equal(div.className, 'svelte-x1o6ra');

component.testName = '';
assert.equal(div.className, ' svelte-x1o6ra');
assert.equal(div.className, 'svelte-x1o6ra');

component.testName = 'testClassName';
assert.equal(div.className, 'testClassName svelte-x1o6ra');
Expand Down
8 changes: 4 additions & 4 deletions ...s/svelte/tests/runtime-legacy/samples/attribute-null-func-classname-with-style/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ export default test({
assert.equal(div.className, 'testClassName svelte-x1o6ra');

component.testName = null;
assert.equal(div.className, ' svelte-x1o6ra');
assert.equal(div.className, 'svelte-x1o6ra');

component.testName = undefined;
assert.equal(div.className, ' svelte-x1o6ra');
assert.equal(div.className, 'svelte-x1o6ra');

component.testName = undefined + '';
assert.equal(div.className, 'undefined svelte-x1o6ra');
Expand All @@ -40,9 +40,9 @@ export default test({
assert.equal(div.className, 'true svelte-x1o6ra');

component.testName = {};
assert.equal(div.className, ' svelte-x1o6ra');
assert.equal(div.className, 'svelte-x1o6ra');

component.testName = '';
assert.equal(div.className, ' svelte-x1o6ra');
assert.equal(div.className, 'svelte-x1o6ra');
}
});
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy