Skip to content

docs: fix 'rune' phonetic spelling #15445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

matthewCmatt
Copy link
Contributor

The intro docs page for runes includes a flavor-text dictionary entry for "rune".
https://svelte.dev/docs/svelte/what-are-runes

This seems to have some special/invalid character, which is displayed differently in different browsers:

Browsers
Chromium
Screenshot 2025-03-04 at 8 40 44 PM
Firefox
Screenshot 2025-03-04 at 8 42 52 PM
Safari
Screenshot 2025-03-04 at 8 42 59 PM

This should be switched to something that displays normally on all popular browsers.

I opted to use the International Phonetic Alphabet notation from OED, but I'll gladly tweak it to anything that seems sensible and displays well on different browsers.

I didn't test this fix, as I don't have the docs site dev environment setup. Would be happy to set it up if needed, but the svelte-dev repo isn't super clear on how to run it against docs changes from this repository?

Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 4176878

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matthewCmatt matthewCmatt changed the title docs: Fix 'rune' phonetic spelling docs: fix 'rune' phonetic spelling Mar 5, 2025
@svelte-docs-bot
Copy link

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15445

@matthewCmatt
Copy link
Contributor Author

Oop, didn't realize external PRs get a review app! Change should be visible at https://svelte-dev-git-preview-svelte-15445-svelte.vercel.app/docs/svelte/what-are-runes

Updated screenshots:

Browsers
Chromium
Screenshot 2025-03-04 at 9 08 48 PM
Firefox
Screenshot 2025-03-04 at 9 09 11 PM
Safari
Screenshot 2025-03-04 at 9 09 26 PM

@Rich-Harris Rich-Harris merged commit 0164215 into sveltejs:main Mar 5, 2025
9 checks passed
@Rich-Harris
Copy link
Member

thank you! this is what i get for using firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy