docs: correct toggle function in lifecycle hooks example #15486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to the Svelte project.
Fix toggle function in lifecycle hooks example
Issue
Fix for Issue #15404 where the theme toggle callback function in the lifecycle hooks documentation was using an undefined
toggleValue
variable.Changes
toggle()
function to correctly toggle the theme state variabletoggleValue
to properly using the existingtheme
variableTesting
Verified that the modified example code is now consistent with the correct implementation shown in the "After" playground link.
This PR ensures that users following the documentation won't encounter undefined variable errors when implementing dark mode toggling.
Fixes #15404
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint