Skip to content

fix: avoid microtask in flushSync #16394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025
Merged

fix: avoid microtask in flushSync #16394

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5028dc
fix: avoid microtask in flushSync
Rich-Harris Jul 16, 2025
eac029c
fix/simplify
Rich-Harris Jul 16, 2025
4126a8d
on second thoughts
Rich-Harris Jul 16, 2025
282cd94
changeset
Rich-Harris Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix/simplify
  • Loading branch information
@Rich-Harris
Rich-Harris committed Jul 16, 2025
commit eac029c7257f35376bdcd5315b6e617455c0c416
9 changes: 2 additions & 7 deletions packages/svelte/src/internal/client/reactivity/batch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ let queued_root_effects = [];
let last_scheduled_effect = null;

let is_flushing = false;
let in_flush_sync = false;

export class Batch {
/**
Expand Down Expand Up @@ -417,7 +416,7 @@ export class Batch {
return (this.#deferred ??= deferred()).promise;
}

static ensure() {
static ensure(in_flush_sync = false) {
if (current_batch === null) {
const batch = (current_batch = new Batch());
batches.add(current_batch);
Expand Down Expand Up @@ -446,15 +445,13 @@ export class Batch {
* @returns {T}
*/
export function flushSync(fn) {
in_flush_sync = true;

if (async_mode_flag && active_effect !== null) {
e.flush_sync_in_effect();
}

var result;

const batch = Batch.ensure();
const batch = Batch.ensure(true);

if (fn) {
batch.flush_effects();
Expand All @@ -478,8 +475,6 @@ export function flushSync(fn) {
dev_effect_stack = [];
}

in_flush_sync = false;

return /** @type {T} */ (result);
}

Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy