-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: transform input defaults from spread #16481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6f6a24a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I think Also this should also be applied to |
The |
I agree...but you can also do that with a |
Unfortunately, |
I don't believe so - textarea doesn't support a |
According to specs we have: So, <input value="foo" defaultValue="bar"> because they both set the same attribute |
I would expect this to SSR into |
But it can be done only if JS is enabled. <input bind:value defaultValue=""> to allow resetting a pre-filled form into an empty one. |
Fixes #16479.
The default props:
defaultValue
,defaultChecked
for inputs were previously not renamed for SSR when set from an object spread, leading to unexpected results.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint