Skip to content

fix: throw on duplicate class field declarations #16502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 25, 2025
Merged

fix: throw on duplicate class field declarations #16502

merged 7 commits into from
Jul 25, 2025

Conversation

Ocean-OS
Copy link
Member

@Ocean-OS Ocean-OS commented Jul 25, 2025 •
edited
Loading

Closes #16501

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a8913f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-16502-svelte.vercel.app/

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16502

@7nik
Copy link
Contributor

7nik commented Jul 25, 2025

It's funny that this

class Store {
	get username() { return 1 }
	get username() { return 2 }
	get username() { return 3 }
	get username() { return 4 }
}

is a valid class 😃

@7nik
Copy link
Contributor

7nik commented Jul 25, 2025

What about this case?:

class Store {
	constructor(name) {
		this.username = $state(name)
	}
	get username() { return this.username }
}

@Ocean-OS
Copy link
Member Author

Both of the cases should be fixed now.

7nik
7nik reviewed Jul 25, 2025
View reviewed changes
7nik
7nik approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@7nik 7nik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ocean-OS Ocean-OS merged commit b0f9ea3 into main Jul 25, 2025
15 checks passed
@Ocean-OS Ocean-OS deleted the gh-16501 branch July 25, 2025 22:57
@github-actions github-actions bot mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7nik 7nik 7nik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writing getter for public class stateful variables transforms into duplicate getters
2 participants
@Ocean-OS @7nik
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy