Skip to content

fix: rewrite smart quotes logic #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: rewrite smart quotes logic #1325

wants to merge 8 commits into from
+26 −14

Conversation

Ocean-OS
Copy link
Member

@Ocean-OS Ocean-OS commented Apr 28, 2025 •
edited by eltigerchino
Loading

Closes #781. I'm not entirely sure on what first does, or if I'm using it correctly in the logic, but everything else should be good.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

@vercel Vercel
Copy link

vercel bot commented Apr 28, 2025

@Ocean-OS is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
svelte-dev ❌ Failed (Inspect) Aug 1, 2025 8:39am

eltigerchino
eltigerchino reviewed Aug 1, 2025
View reviewed changes
@eltigerchino
Copy link
Member

I'm not entirely sure on what first does

I think first is used to tell if we're in a complete sentence or substring. It's only being used when we're processing the shiki tokens token by token so that a substring such as example" that's part of a bigger string "an example" will get the right quotation direction.

eltigerchino
eltigerchino reviewed Aug 1, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eltigerchino eltigerchino eltigerchino left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
docs (design)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

more smart quote woes
2 participants
@Ocean-OS @eltigerchino
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy