Skip to content

fix: prevent the tutorial erroring after navigating #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the tutorial erroring after navigating
The `Workspace.reset` method was changed in a non-backward compatible
way in commit eb1eb2b, which caused the call in the tutorial pages
to not pass the proper value for the selected file. This was missed
because the tutorial page didn't use `PageProps` for typing.
  • Loading branch information
zqianem committed May 18, 2025
commit cee7daf14fe42b21622f4c3e5d962e792a260306
9 changes: 3 additions & 6 deletions apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,9 @@
import Controls from './Controls.svelte';
import Editor from '@sveltejs/repl/editor';
import type { Snapshot } from './$types.js';
import type { PageProps } from './$types';

interface Props {
data: any;
}

let { data }: Props = $props();
let { data }: PageProps = $props();

let path = data.exercise.path;
let show_editor = $state(false);
Expand Down Expand Up @@ -204,7 +201,7 @@
sidebar.scrollTop = 0;
}

workspace.reset(Object.values(a), data.exercise.focus);
workspace.reset(Object.values(a), { tailwind: false }, data.exercise.focus);

const will_delete = previous_files.some((file) => !(file.name in a));

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy