fix: fix diagnostics tooltip being behind buttons #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WarningImHack3r is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted that on Paolo's TWIS today: diagnostics that are high enough and long enough are obstructed by the top buttons, which have a z-index.
This PR addresses that issue: it removes the
z-index: 999on the buttons and adds az-index: 2to both parts of the buttons’ hover tooltips — likely the reason the originalz-indexwas used for.I'm not sure if there are other reasons for this high
z-indexvalue beyond the tooltips; if so, please let me know and I'll add them to the fix as well.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.