Skip to content

fix: avoid activating search box when cmd + shift + k is pressed #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Only focus search when no shiftKey
When using Ctrl/Cmd+Shift+k in repl/tutorial you expect the current line to be removed, instead search in the nav-bar is focused. This change should fix that.
  • Loading branch information
neorth authored Jun 13, 2025
commit 972090c7b2eea3cfb1e1222b51fae1e7c33f94d9
2 changes: 1 addition & 1 deletion packages/site-kit/src/lib/search/SearchBox.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ It appears when the user clicks on the `Search` component or presses the corresp

<svelte:window
onkeydown={(e) => {
if (e.key === 'k' && (navigator.platform === 'MacIntel' ? e.metaKey : e.ctrlKey)) {
if (e.key === 'k' && !e.shiftKey && (navigator.platform === 'MacIntel' ? e.metaKey : e.ctrlKey)) {
e.preventDefault();
search.query = '';

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy