feat: allow disabling of axis labels using text={false} or text={null} #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new text prop to AxisX and AxisY to allow disabling tick labels, updates internal helpers to respect this flag, and provides examples and tests illustrating the feature.
- Introduce
textprop inAxisX,AxisY, and their base helpers. - Wrap label rendering in
BaseAxisX.svelteandBaseAxisY.sveltewithif (text)guards. - Add a Svelte example (
major-minor.svelte) and a unit test forAxisX.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/marks/helpers/BaseAxisX.svelte | Added text prop and conditional label rendering (plus leftover debug). |
| src/lib/marks/helpers/BaseAxisY.svelte | Added text prop and wrapped label loops in if (text). |
| src/lib/marks/AxisX.svelte | Exposed text prop to the base helper. |
| src/lib/marks/AxisY.svelte | Exposed text prop to the base helper. |
| src/tests/axisX.test.ts | New test verifying labels are omitted when text is null. |
| src/routes/examples/axis/major-minor.svelte | Example showing major and minor ticks with labels disabled. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-95
# or install the specific version
npm install svelteplot@0.2.9-pr-95.0 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-95
# or install the specific version
npm install svelteplot@0.2.9-pr-95.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #77
This pull request introduces a new
textproperty to theAxisXandAxisYcomponents, enabling users to toggle tick labels on or off. The changes improve flexibility in axis customization and include updates to related helper components, examples, and tests.Examples and Documentation:
textproperty to create minor tick lines without labels.Testing Improvements:
textproperty inAxisX, ensuring tick labels are omitted whentextis set tonull.