[4.3] Remove unused local variables

fancyweb · fancyweb · commit 30a51b2401ee · 2019-10-30T13:58:49.000+01:00
diff --git a/Tests/Adapter/AdapterTestCase.php b/Tests/Adapter/AdapterTestCase.php
@@ -87,8 +87,8 @@ public function testRecursiveGet()
         $cache = $this->createCachePool(0, __FUNCTION__);
 
         $v = $cache->get('k1', function () use (&$counter, $cache) {
-            $v = $cache->get('k2', function () use (&$counter) { return ++$counter; });
-            $v = $cache->get('k2', function () use (&$counter) { return ++$counter; });
+            $cache->get('k2', function () use (&$counter) { return ++$counter; });
+            $v = $cache->get('k2', function () use (&$counter) { return ++$counter; }); // ensure the callback is called once
 
             return $v;
         });
diff --git a/Tests/Adapter/NullAdapterTest.php b/Tests/Adapter/NullAdapterTest.php
@@ -39,7 +39,7 @@ public function testGet()
         $adapter = $this->createCachePool();
 
         $fetched = [];
-        $item = $adapter->get('myKey', function ($item) use (&$fetched) { $fetched[] = $item; });
+        $adapter->get('myKey', function ($item) use (&$fetched) { $fetched[] = $item; });
         $this->assertCount(1, $fetched);
         $item = $fetched[0];
         $this->assertFalse($item->isHit());
diff --git a/Tests/Adapter/PdoDbalAdapterTest.php b/Tests/Adapter/PdoDbalAdapterTest.php
@@ -31,8 +31,6 @@ public static function setUpBeforeClass(): void
         }
 
         self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache');
-
-        $pool = new PdoAdapter(DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile]));
     }
 
     public static function tearDownAfterClass(): void

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,6 @@ public static function setUpBeforeClass(): void`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache');`
`34`		`-`
`35`		`- $pool = new PdoAdapter(DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile]));`
`36`	`34`	`}`
`37`	`35`
`38`	`36`	`public static function tearDownAfterClass(): void`