Wire DebugLoggerConfigurator on Symfony 6.4+ #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Aug 23, 2023
| */ | ||
| public function getConfigTreeBuilder() | ||
| public function getConfigTreeBuilder(): TreeBuilder |
There was a problem hiding this comment.
Technically this is a BC break for anyone that extends Configuration, but let's be pragmatic: nobody does that.
There was a problem hiding this comment.
Those configuration classes should be @internal anyway
stof
approved these changes
Aug 23, 2023
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire symfony/symfony#51284 and allow Symfony v7, which will just work after symfony/symfony#51458 is merged.