Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taluu
approved these changes
Dec 8, 2019
lyrixx
approved these changes
Dec 17, 2019
bastnic
reviewed
Dec 17, 2019
BoShurik
reviewed
Dec 17, 2019
bendavies
reviewed
Dec 17, 2019
yceruto
approved these changes
Dec 17, 2019
Can we be sure that no recipe uses something else than yaml? Even contrib ones? All those would be ignored suddenly. |
|
IIRC the CI not enforces yaml. IIRC also, I had a look at the repos back then. |
Tobion
reviewed
Jun 8, 2020
| { | ||
| $container->addResource(new FileResource($this->getProjectDir().'/config/bundles.php')); | ||
| $container->setParameter('container.dumper.inline_class_loader', \PHP_VERSION_ID < 70400); | ||
| $container->setParameter('container.dumper.inline_factories', true); |
There was a problem hiding this comment.
For reference why this got removed: symfony/symfony#36193
There was a problem hiding this comment.
Thank you for this note @Tobion! Super helpful.
ob-ivan
pushed a commit
to ob-ivan/ommacomics
that referenced
this pull request
Aug 11, 2021
ob-ivan
pushed a commit
to ob-ivan/ommacomics
that referenced
this pull request
Sep 3, 2021
ob-ivan
pushed a commit
to ob-ivan/ommacomics
that referenced
this pull request
Feb 13, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires symfony/symfony#34873
Removes also the multi file-extensions support. Nobody needs that by default AFAIK. Ppl that do can easily add it back.