Add changelog

alexander-schranz · alexander-schranz · commit 596b2c02d2d0 · 2020-10-20T14:35:54.000+02:00
diff --git a/src/Symfony/Component/BrowserKit/AbstractBrowser.php b/src/Symfony/Component/BrowserKit/AbstractBrowser.php
@@ -162,7 +162,7 @@ public function xmlHttpRequest(string $method, string $uri, array $parameters =
     }
 
     /**
-     * Converts the request parameters into a json string and use it as request content.
+     * Converts the request parameters into a json string and used it as request content.
      */
     public function jsonRequest(string $method, string $uri, array $parameters = [], array $server = [], bool $changeHistory = true): Crawler
     {
diff --git a/src/Symfony/Component/BrowserKit/CHANGELOG.md b/src/Symfony/Component/BrowserKit/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+5.3.0
+-----
+
+ * Added `jsonRequest` method to `AbstractBrowser`
+
 4.3.0
 -----
 
diff --git a/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php b/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php
@@ -64,11 +64,11 @@ public function testJsonRequest()
     {
         $client = $this->getBrowser();
         $client->jsonRequest('GET', 'http://example.com/', ['param' => 1], [], true);
-        $this->assertEquals($client->getRequest()->getServer()['CONTENT_TYPE'], 'application/json');
-        $this->assertEquals($client->getRequest()->getServer()['HTTP_ACCEPT'], 'application/json');
+        $this->assertSame('application/json', $client->getRequest()->getServer()['CONTENT_TYPE']);
+        $this->assertSame('application/json', $client->getRequest()->getServer()['HTTP_ACCEPT']);
         $this->assertFalse($client->getServerParameter('CONTENT_TYPE', false));
         $this->assertFalse($client->getServerParameter('HTTP_ACCEPT', false));
-        $this->assertEquals('{"param":1}', $client->getRequest()->getContent());
+        $this->assertSame('{"param":1}', $client->getRequest()->getContent());
     }
 
     public function testGetRequestWithIpAsHttpHost()

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ public function xmlHttpRequest(string $method, string $uri, array $parameters =`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`/**`
`165`		`- * Converts the request parameters into a json string and use it as request content.`
	`165`	`+ * Converts the request parameters into a json string and used it as request content.`
`166`	`166`	`*/`
`167`	`167`	`public function jsonRequest(string $method, string $uri, array $parameters = [], array $server = [], bool $changeHistory = true): Crawler`
`168`	`168`	`{`
Original file line number	Diff line number	Diff line change
`@@ -64,11 +64,11 @@ public function testJsonRequest()`
`64`	`64`	`{`
`65`	`65`	`$client = $this->getBrowser();`
`66`	`66`	`$client->jsonRequest('GET', 'http://example.com/', ['param' => 1], [], true);`
`67`		`- $this->assertEquals($client->getRequest()->getServer()['CONTENT_TYPE'], 'application/json');`
`68`		`- $this->assertEquals($client->getRequest()->getServer()['HTTP_ACCEPT'], 'application/json');`
	`67`	`+ $this->assertSame('application/json', $client->getRequest()->getServer()['CONTENT_TYPE']);`
	`68`	`+ $this->assertSame('application/json', $client->getRequest()->getServer()['HTTP_ACCEPT']);`
`69`	`69`	`$this->assertFalse($client->getServerParameter('CONTENT_TYPE', false));`
`70`	`70`	`$this->assertFalse($client->getServerParameter('HTTP_ACCEPT', false));`
`71`		`- $this->assertEquals('{"param":1}', $client->getRequest()->getContent());`
	`71`	`+ $this->assertSame('{"param":1}', $client->getRequest()->getContent());`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`public function testGetRequestWithIpAsHttpHost()`