minor #32399 [Messenger] Don't pass objects as class name to ContainerBuilder::register (derrabus)

Tobion · Tobion · commit 8e07e7773f11 · 2019-07-05T21:49:02.000+02:00
This PR was merged into the 4.2 branch. Discussion ---------- [Messenger] Don't pass objects as class name to ContainerBuilder::register | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Fixed a broken test that was discovered while working on #32390. Commits ------- e110603 Don't pass objects as class name to ContainerBuilder::register.
diff --git a/src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php b/src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php
@@ -448,10 +448,8 @@ public function testNeedsToHandleAtLeastOneMessage()
 
     public function testRegistersTraceableBusesToCollector()
     {
-        $dataCollector = $this->getMockBuilder(MessengerDataCollector::class)->getMock();
-
         $container = $this->getContainerBuilder($fooBusId = 'messenger.bus.foo');
-        $container->register('data_collector.messenger', $dataCollector);
+        $container->register('data_collector.messenger', MessengerDataCollector::class);
         $container->setParameter('kernel.debug', true);
 
         (new MessengerPass())->process($container);
