bug #57646 [Serializer] Raise correct exception in ArrayDenormalizer when called without a nested denormalizer (derrabus)

xabbuh · xabbuh · commit a4249327dafc · 2024-07-17T06:37:40.000+02:00
This PR was merged into the 7.0 branch. Discussion ---------- [Serializer] Raise correct exception in `ArrayDenormalizer` when called without a nested denormalizer | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT The `$denormalizer` property is not nullable and will be uninitialized by default. Because of that, the check that makes sure that the ArrayDenormalizer is not used before setting a nested denormalizer will produce an obscure error instead of raising the proper exception. Commits ------- ed0d3e5 [Serializer] Raise correct exception in ArrayDenormalizer
diff --git a/src/Symfony/Component/Serializer/Normalizer/ArrayDenormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ArrayDenormalizer.php
@@ -42,7 +42,7 @@ public function getSupportedTypes(?string $format): array
      */
     public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): array
     {
-        if (null === $this->denormalizer) {
+        if (!isset($this->denormalizer)) {
             throw new BadMethodCallException('Please set a denormalizer before calling denormalize()!');
         }
         if (!\is_array($data)) {
@@ -72,7 +72,7 @@ public function denormalize(mixed $data, string $type, ?string $format = null, a
 
     public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool
     {
-        if (null === $this->denormalizer) {
+        if (!isset($this->denormalizer)) {
             throw new BadMethodCallException(sprintf('The nested denormalizer needs to be set to allow "%s()" to be used.', __METHOD__));
         }
 
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ArrayDenormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ArrayDenormalizerTest.php
@@ -108,6 +108,22 @@ public function testSupportsNoArray()
             )
         );
     }
+
+    public function testDenormalizeWithoutDenormalizer()
+    {
+        $arrayDenormalizer = new ArrayDenormalizer();
+
+        $this->expectException(\BadMethodCallException::class);
+        $arrayDenormalizer->denormalize([], 'string[]');
+    }
+
+    public function testSupportsDenormalizationWithoutDenormalizer()
+    {
+        $arrayDenormalizer = new ArrayDenormalizer();
+
+        $this->expectException(\BadMethodCallException::class);
+        $arrayDenormalizer->supportsDenormalization([], 'string[]');
+    }
 }
 
 class ArrayDummy

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function getSupportedTypes(?string $format): array`
`42`	`42`	`*/`
`43`	`43`	`public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): array`
`44`	`44`	`{`
`45`		`- if (null === $this->denormalizer) {`
	`45`	`+ if (!isset($this->denormalizer)) {`
`46`	`46`	`throw new BadMethodCallException('Please set a denormalizer before calling denormalize()!');`
`47`	`47`	`}`
`48`	`48`	`if (!\is_array($data)) {`
`@@ -72,7 +72,7 @@ public function denormalize(mixed $data, string $type, ?string $format = null, a`
`72`	`72`
`73`	`73`	`public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool`
`74`	`74`	`{`
`75`		`- if (null === $this->denormalizer) {`
	`75`	`+ if (!isset($this->denormalizer)) {`
`76`	`76`	`throw new BadMethodCallException(sprintf('The nested denormalizer needs to be set to allow "%s()" to be used.', __METHOD__));`
`77`	`77`	`}`
`78`	`78`