minor #61178 [AssetMapper] Make argument $projectDir of ImportMapRequireCommand mandatory (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit ec69e60e4604 · 2025-07-21T14:36:27.000+02:00
This PR was merged into the 8.0 branch. Discussion ---------- [AssetMapper] Make argument `$projectDir` of `ImportMapRequireCommand` mandatory | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- 02e28c4 [AssetMapper] Make argument `$projectDir` of `ImportMapRequireCommand` mandatory
diff --git a/src/Symfony/Component/AssetMapper/CHANGELOG.md b/src/Symfony/Component/AssetMapper/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Remove `ImportMapConfigReader::splitPackageNameAndFilePath()`, use `ImportMapEntry::splitPackageNameAndFilePath()` instead
+ * Make argument `$projectDir` of `ImportMapRequireCommand` mandatory
 
 7.3
 ---
diff --git a/src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php b/src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php
@@ -36,12 +36,8 @@ final class ImportMapRequireCommand extends Command
     public function __construct(
         private readonly ImportMapManager $importMapManager,
         private readonly ImportMapVersionChecker $importMapVersionChecker,
-        private readonly ?string $projectDir = null,
+        private readonly string $projectDir,
     ) {
-        if (null === $projectDir) {
-            trigger_deprecation('symfony/asset-mapper', '7.3', 'The "%s()" method will have a new `string $projectDir` argument in version 8.0, not defining it is deprecated.', __METHOD__);
-        }
-
         parent::__construct();
     }
 
@@ -149,9 +145,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 array_map(fn (ImportMapEntry $package): array => [
                     $package->importName,
                     $package->version ?? '-',
-                    // BC layer for AssetMapper < 7.3
-                    // When `projectDir` is not null, we use the absolute path of the package
-                    null !== $this->projectDir ? Path::makeRelative($package->path, $this->projectDir) : $package->path,
+                    Path::makeRelative($package->path, $this->projectDir),
                 ], $newPackages),
             );
         }
