[DomCrawler] Fixed a forgotten case of complex XPath queries #10987
Conversation
|
@stof looks like it fixed now, thanks . Also i don see any CHANGELOG line for this issue, you dont include it in CHANGELOG since it is minor version or what ? |
|
@Ragazzo for bug fixes in minor versions, the changelog is updated automatically by Fabien when doing a release. |
|
ok, i see you dont include names of developers who fixed and found those bugs and issue number, can be hard to track it down for changes . |
|
the automatic changelog includes it: https://github.com/symfony/symfony/blob/master/CHANGELOG-2.3.md (well, it includes the github username of the guy fixing the issue, not the name) |
|
ah , i see , thank you for clarifying this one . Overall fix is valid , i confirm it . |
|
Thank you @stof for taking care of this regression. |
…es (stof) This PR was merged into the 2.3 branch. Discussion ---------- [DomCrawler] Fixed a forgotten case of complex XPath queries | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10986 | License | MIT | Doc PR | n/a This fixes the case I forgot when rewritting the XPath to avoid making it produce invalid queries. I ran the new tests against the old implementation first, to ensure they cover the BC properly. I could have detected it by running the Mink 1.5 testsuite with the new code (which is the case for people reporting the bug), but I only ran it for Mink 1.6 which does not produce such XPath anymore. Commits ------- a9de61e [DomCrawler] Fixed a forgotten case of complex XPath queries
|
@Ragazzo 2.3 will get merged into newer branch (it is done on a regular basis). This has not yet been done after the merge of this PR though |
|
ok, @stof can you say when it will be merged so we can use |
|
@Ragazzo Teh constraint I gave takes care to exclude the affected releases. If you use minimum-stability dev, you should avoid using the dev version of 2.4 until the fix is propagated to it as well (but excluding it in codeception itself is a bad idea as the dev version will be compatible again as soon as the fix is propagated). |
This fixes the case I forgot when rewritting the XPath to avoid making it produce invalid queries. I ran the new tests against the old implementation first, to ensure they cover the BC properly.
I could have detected it by running the Mink 1.5 testsuite with the new code (which is the case for people reporting the bug), but I only ran it for Mink 1.6 which does not produce such XPath anymore.